fix(ci): Disable bindings for e2e tests

ngrok · Jan 13, 2025 · 6a02478 · 6a02478
1 parent 96ccc03
commit 6a02478
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 30 deletions.
diff --git a/Makefile b/Makefile
@@ -212,7 +212,7 @@ deploy_for_e2e: _deploy-check-env-vars docker-build manifests kustomize _helm_se
 		--set log.level=debug \
 		--set log.stacktraceLevel=panic \
 		--set metaData.env=local,metaData.from=makefile \
-		--set bindings.enabled=true \
+		--set bindings.enabled=false \
 		--set bindings.name=$(E2E_BINDING_NAME) \
 		--set bindings.description="Example binding for CI e2e tests" \
 		--set bindings.allowedURLs='{*.e2e}' \

diff --git a/tests/chainsaw/operator-registration/chainsaw-test.yaml b/tests/chainsaw/operator-registration/chainsaw-test.yaml
@@ -20,39 +20,39 @@ spec:
               namespace: ngrok-operator
             enabledFeatures:
             - ingress
-            - bindings
+            # - bindings
             # - gateway
-            binding:
-              tlsSecretName: ngrok-operator-default-tls
-              (name != null && starts_with(name, 'k8s/')): true
+            # binding:
+            #  tlsSecretName: ngrok-operator-default-tls
+            #  (name != null && starts_with(name, 'k8s/')): true
           status:
             registrationStatus: registered
             (id != null && starts_with(id, 'k8sop_')): true
             (uri != null): true
 
-  - name: assert Secret/ngrok-operator-default-tls exists (CSR is signed)
-    try:
-    - assert:
-        resource:
-          apiVersion: v1
-          kind: Secret
-          metadata:
-            name: ngrok-operator-default-tls
-            namespace: ngrok-operator
-          type: kubernetes.io/tls
-          data:
-            ("tls.crt" != null): true
-            ("tls.csr" != null): true
-            ("tls.key" != null): true
+  # - name: assert Secret/ngrok-operator-default-tls exists (CSR is signed)
+  #   try:
+  #   - assert:
+  #       resource:
+  #         apiVersion: v1
+  #         kind: Secret
+  #         metadata:
+  #           name: ngrok-operator-default-tls
+  #           namespace: ngrok-operator
+  #         type: kubernetes.io/tls
+  #         data:
+  #           ("tls.crt" != null): true
+  #           ("tls.csr" != null): true
+  #           ("tls.key" != null): true
 
-  - name: assert Configmap/ngrok-intermediate-ca exists (tunnels/forwarders will work)
-    try:
-    - assert:
-        resource:
-          apiVersion: v1
-          kind: ConfigMap
-          metadata:
-            name: ngrok-intermediate-ca
-            namespace: ngrok-operator
-          data:
-            ("root.crt" != null): true
+  # - name: assert Configmap/ngrok-intermediate-ca exists (tunnels/forwarders will work)
+  #   try:
+  #   - assert:
+  #       resource:
+  #         apiVersion: v1
+  #         kind: ConfigMap
+  #         metadata:
+  #           name: ngrok-intermediate-ca
+  #           namespace: ngrok-operator
+  #         data:
+  #           ("root.crt" != null): true