TLSEdge support #312
Merged
TLSEdge support #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/controller
jrobsonchase
force-pushed
the
josh/tlsedges
branch
from
9a89538 to
f0338f2
Compare
jonstacks
approved these changes
Oct 6, 2023
| return err | ||
| } | ||
|
|
||
| if err := r.updateIPRestrictionModule(ctx, edge, remoteEdge); err != nil { |
There was a problem hiding this comment.
nit: We could just return r.updateIPRestrictionMoudle(ctx, edge, remoteEdge) here right?
There was a problem hiding this comment.
Could, but I kinda like having the symmetry among the things-to-update 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ngrok-private/ngrok#22654
What
Add support for TLS Edges. No support as an ingress yet, but direct use of the tlsedge crd is functional.
How
Mostly copy-paste the TCP types/controller. Slight variations around hostport assignment, but otherwise identical currently.
Breaking Changes
Should be none, also fixing a couple of bugs along the way.