Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update references from kubernetes-ingress-controller -> ngrok-operator #426

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Update references from kubernetes-ingress-controller -> ngrok-operator #426

merged 3 commits into from
Sep 10, 2024

Conversation

jonstacks
Copy link
Collaborator

What

Renaming references from project name change

How

  • rg github.com/ngrok/kubernetes-ingress-controller . --files-with-matches | xargs sed -i 's/github.com\/ngrok\/kubernetes-ingress-controller/github.com\/ngrok\/ngrok-operator/g'
  • Lots of other finding and replacing
  • Some of the references have not been updated at this time as we work on a migration strategy for the controllers

Breaking Changes

Yes, mainly the helm chart and image renaming

@jonstacks
chore(rename): Replace kubernetes-ingress-controller with ngrok-operator
4a5e467 
rg github.com/ngrok/kubernetes-ingress-controller . --files-with-matches | xargs sed -i 's/github.com\/ngrok\/kubernetes-ingress-controller/github.com\/ngrok\/ngrok-operator/g'
@jonstacks
chore(rename): Move helm/ingress-controller -> helm/ngrok-operator
2d24958
@jonstacks jonstacks self-assigned this Sep 10, 2024
@jonstacks jonstacks requested a review from a team as a code owner September 10, 2024 20:07
@github-actions github-actions bot added documentation Improvements or additions to documentation testing area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart meta/project Issues/PRs related to maintaining the project area/ci Issues/PRs relating to CI labels Sep 10, 2024
@github-actions GitHub Actions
Copy link

👋 Looks like there are changes in the Helm Chart's Chart.yaml file. Upon merge, a new release of the helm chart will be created if the Chart's version was changed.

@jonstacks
Copy link
Collaborator Author

The readme generator should succeed for future PRs after this is merged into main.

hjkatz
hjkatz approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@hjkatz hjkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions GitHub Actions
Copy link

👋 Looks like there are changes in the Helm Chart's Chart.yaml file. Upon merge, a new release of the helm chart will be created if the Chart's version was changed.

@jonstacks jonstacks merged commit 1e2367d into ngrok:main Sep 10, 2024
9 of 10 checks passed
@jonstacks jonstacks deleted the naming-update branch September 10, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjkatz hjkatz hjkatz approved these changes

Assignees

@jonstacks jonstacks

Labels
area/ci Issues/PRs relating to CI area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart documentation Improvements or additions to documentation meta/project Issues/PRs related to maintaining the project testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonstacks @hjkatz