Add ngrok enriched errors #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/controller
hjkatz
force-pushed
the
hkatz/enriched-errors
branch
from
3707f6d to
486299d
Compare
masonj5n
reviewed
Jan 23, 2025
| return ctrl.Result{RequeueAfter: 30 * time.Second}, nerr | ||
| case ngrok.IsErrorCode(nerr, ngrokapi.NgrokOpErrFailedToCreateUpstreamService.Code, ngrokapi.NgrokOpErrFailedToCreateTargetService.Code): | ||
| return ctrl.Result{RequeueAfter: 1 * time.Minute}, nerr | ||
| case ngrok.IsErrorCode(nerr, ngrokapi.NgrokOpErrEndpointDenied.Code): |
There was a problem hiding this comment.
this won't be relevant anymore, but we can remove it after we remove the enriched error on the other side
masonj5n
force-pushed
the
hkatz/enriched-errors
branch
4 times, most recently
from
2bfebdb to
a9884be
Compare
masonj5n
force-pushed
the
hkatz/enriched-errors
branch
from
a9884be to
ae9d29f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
==========================================
- Coverage 23.67% 23.60% -0.07%
==========================================
Files 88 89 +1
Lines 12484 12521 +37
==========================================
Hits 2955 2955
- Misses 9339 9376 +37
Partials 190 190 ☔ View full report in Codecov by Sentry. |
masonj5n
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Describe what the change is solving
Add support for
ngrok.Errorand enriched errorsHow
Describe the solution
New package
Breaking Changes
Are there any breaking changes in this PR?