fix(helm): .Values.podLabels should not be included in the deployment selectors #558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #556
What
Fixes
.Values.podLabels
being included in the deployments'spec.selector.matchLabels
.How
podLabels
templates from the deployments'spec.selector.matchLabels
.podLabels
are added to the pod spec templates, but not the deployments' selector matchLabesl.Breaking Changes
Yes, the
.Values.podLabels
were previously added incorrectly as additional selector labels. If you had previously supplied.Values.podLabels
, you will need to delete the existing deployment. You can do this with minimal downtime by deleting the deployment and orphaning the resources controlled by the deployment.