Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): .Values.podLabels should not be included in the deployment selectors #558

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

jonstacks
Copy link
Collaborator

Fixes #556

What

Fixes .Values.podLabels being included in the deployments' spec.selector.matchLabels.

How

  • Remove podLabels templates from the deployments' spec.selector.matchLabels.
  • Add tests to verify that podLabels are added to the pod spec templates, but not the deployments' selector matchLabesl.

Breaking Changes

Yes, the .Values.podLabels were previously added incorrectly as additional selector labels. If you had previously supplied .Values.podLabels, you will need to delete the existing deployment. You can do this with minimal downtime by deleting the deployment and orphaning the resources controlled by the deployment.

@jonstacks jonstacks added the bug Something isn't working label Dec 18, 2024
@jonstacks jonstacks self-assigned this Dec 18, 2024
@jonstacks jonstacks requested a review from a team as a code owner December 18, 2024 19:21
@github-actions github-actions bot added the area/helm-chart Issues dealing with the helm chart label Dec 18, 2024
@jonstacks jonstacks added this pull request to the merge queue Dec 18, 2024
Merged via the queue into ngrok:main with commit 3a0a3a3 Dec 18, 2024
9 checks passed
@jonstacks jonstacks deleted the issue-556 branch December 18, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm-chart Issues dealing with the helm chart bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] .Values.podLabels are included in the deployment's selector labels
2 participants