refactor(ngrokapi): Refactor ngrokapi package to better support mocking #578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Step 1 in beefing up our test coverage. Rather than returning clients for everything, return interfaces that behave like the actual clients. This will allow us to rely on the interfaces in the rest of the code and eventually substitute mock clients so we can test the behavior of our controllers better.
How
Make interfaces for our clients and replace the actual implementation with the interfaces.
Breaking Changes
No