for the k8s operator resource, remove binding name printcolumn and add endpoint selectors #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/controller
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
=======================================
Coverage 23.87% 23.87%
=======================================
Files 89 89
Lines 12588 12588
=======================================
Hits 3005 3005
Misses 9393 9393
Partials 190 190 ☔ View full report in Codecov by Sentry. |
jonstacks
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The printed columns for the kubernetes operator resource was referencing the deleted Name field and didn't include endpoint selectors, so this changes that!
How
Modify kubebuilder annotations to update the printed columns for the kubernetes operator resource.
Breaking Changes
Does change the "additionalPrinterColumns" field on the kubernetes operator spec but I don't think that should break anything?