LINQ Postgres driver fix.

If Order is used with union first query should be put in parentheses too.
ngs-doo · Nov 3, 2014 · cdf0459 · cdf0459
1 parent f070621
commit cdf0459
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/...Database/Revenj.DatabasePersistence.Oracle/QueryGeneration/QueryComposition/QueryParts.cs b/...Database/Revenj.DatabasePersistence.Oracle/QueryGeneration/QueryComposition/QueryParts.cs
@@ -604,6 +604,7 @@ private void ProcessSetOperators(StringBuilder sb, List<ResultOperatorBase> oper
 				{
 					//TODO missing Concat operator
 					sb.AppendLine("UNION ALL");
+					//TODO if order is used, Oracle will fail anyway
 					var sqe = uro.Source2 as SubQueryExpression;
 					ResultOperators.ForEach(ro =>
 					{

diff --git a/...tabase/Revenj.DatabasePersistence.Postgres/QueryGeneration/QueryComposition/QueryParts.cs b/...tabase/Revenj.DatabasePersistence.Postgres/QueryGeneration/QueryComposition/QueryParts.cs
@@ -664,6 +664,11 @@ private void ProcessSetOperators(StringBuilder sb, List<ResultOperatorBase> oper
 				else
 				{
 					//TODO missing Concat operator
+					if (OrderBy.Count > 0)
+					{
+						sb.Insert(0, '(');
+						sb.AppendLine(")");
+					}
 					sb.AppendLine("UNION ALL");
 					var sqe = uro.Source2 as SubQueryExpression;
 					ResultOperators.ForEach(ro =>