Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix currency formatting with MachineCurrencyFormat #205

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

mskalnik
Copy link
Contributor

The machineFormatCurrency method incorrectly assumed commas as group separators, causing issues with formats using dots or no decimals. Introduce MachineCurrencyFormat to ensure consistent parsing. Update tests to cover all formats and fix validation tests for isIntegerCreator. Build process now runs tests, so the build step was removed from yarn test.

The machineFormatCurrency method incorrectly assumed commas as group
separators, causing issues with formats using dots or no decimals.
Introduce MachineCurrencyFormat to ensure consistent parsing. Update
tests to cover all formats and fix validation tests for
isIntegerCreator. Build process now runs tests, so the build step was
removed from yarn test.
@mskalnik
Copy link
Contributor Author

During this update, validation tests for the isIntegerCreator function failed because the tests had not been updated to reflect earlier changes. To prevent such issues in the future I updated the build to include running tests as part of the build process. Consequently, since tests are now run before the build, the build step was removed from the yarn test command.

@zapov zapov merged commit df6582f into ngs-doo:master Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants