Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmake cleanups #673

Closed
wants to merge 2 commits into from
Closed

Cmake cleanups #673

wants to merge 2 commits into from

Conversation

d235j
Copy link
Collaborator

@d235j d235j commented Jan 22, 2024 •
edited
Loading

This is a heavy refactor of the Cmake scripts to increase the use of autodetection and reduce the reliance on FindVulkan, which is going away in the future and is unreliable when the various components are installed individually.

This requires the related PR for scopehal, tracked at ngscopeclient/scopehal#841.

This is ready for merge; updates to the docs will be needed though.

  • Test on macOS arm64 (individually installed components)
  • Test on macOS arm64 (Vulkan SDK)
  • Test on macOS x86_64 (individually installed components)
  • Test on macOS x86_64 (Vulkan SDK)
  • Test on Linux x86_64 (Arch Linux, individually installed components)
  • Test on Linux x86_64 (Debian oldstable, Vulkan SDK from tarball)
  • Test on Linux x86_64 (Debian oldstable, individual components from Vulkan SDK repo [unsupported config but occasionally used])
  • Test on Linux x86_64 (Debian stable, Vulkan SDK)
  • Test on Linux x86_64 (Debian stable, individually installed components)
  • Test on Linux x86_64 (Fedora current, Vulkan SDK)
  • Test on Linux x86_64 (Fedora current, individually installed components)
    - [ ] Test on Windows MINGW64 (Vulkan SDK) UNSUPPORTED due to C++ linkage differences
  • Test on Windows MINGW64 (individually installed components)

@d235j d235j mentioned this pull request Jan 22, 2024
Merged
@d235j d235j force-pushed the cmake-cleanups branch 3 times, most recently from c9b23ab to f075d1e Compare January 24, 2024 04:05
@d235j d235j marked this pull request as ready for review January 27, 2024 18:57
@d235j
Copy link
Collaborator Author

d235j commented Jan 27, 2024

Seems to work on most platforms; needs a bit more testing on Windows. macOS x86_64 not yet tested either.

@d235j d235j mentioned this pull request Jan 27, 2024
Open
@d235j d235j force-pushed the cmake-cleanups branch 8 times, most recently from 0b0221c to f328c8f Compare January 28, 2024 00:31
@d235j d235j mentioned this pull request Jan 28, 2024
Closed
@d235j d235j force-pushed the cmake-cleanups branch 4 times, most recently from a86b158 to 594b0d9 Compare January 29, 2024 23:13
@d235j d235j force-pushed the cmake-cleanups branch 3 times, most recently from dead8a2 to 48103ac Compare February 8, 2024 04:33
@azonenberg azonenberg mentioned this pull request Feb 8, 2024
Closed
@azonenberg azonenberg closed this Feb 8, 2024
@d235j
Copy link
Collaborator Author

d235j commented Feb 8, 2024

This was merged together with #684.

@d235j d235j deleted the cmake-cleanups branch February 8, 2024 05:57
@d235j d235j mentioned this pull request Feb 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d235j @azonenberg