8bit/16bit data transfer mode setting for Rigol DHO models. #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this needs the submodule bump for ngscopeclient/scopehal#900. Other than that, it seems to work: there is visibly more quantization in an 8 bit capture than a 12 bit capture on my screen, and it takes much longer to download a capture! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by joshua_, here is the 16bit data transfert mode for Rigol DHO models (settings part).
Tested OK on my DHO804. Should work on DHO1000/4000 as well.
I used the same default/8bit/16bit setting system as for Siglent HD models.
Goes with the companion PR on scopehal : ngscopeclient/scopehal#900