Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich UI support for StreamBrowserDialog on oscilloscopes #765

Conversation

jwise
Copy link
Contributor

@jwise jwise commented Sep 27, 2024

This is a draft PR to experiment with some UI for #760 and #761, and in general, the concept of making the StreamBrowserDialog meaningfully richer in showing instrument and system status. Here is what I have right now:

image

Obviously there is going to be a lot of stuff to add and cleanup to do before this is ready to merge, and probably will include some scopehal changes, but this is the current UI metaphor set that I'm playing with. Title bars are still draggable, for instance, but other parts are not, and I think this makes some sense. Some things to consider at some point:

  • Do something sensible if the Stream Browser is not wide enough to contain a badge
  • Show channel properties
  • Maybe make better use of wide horizontal Stream Browsers to provide more information in fewer lines (i.e., channel coupling?)
  • Trigger settings seem like they are part of an oscilloscope?
  • At that point, is it really even called a Stream Browser if copying Streams around is just a small part of its functionality?
  • Should there be a UI affordance of 'things that you can drag' to indicate 'try dragging me to a filter graph'? (Think, for instance, Apple's Interface Builder has the little blue bullseye for 'draggable and droppable things'.)

jwise and others added 16 commits October 8, 2024 00:39
…e, and fall back on a shorter string if there is not
…e, and then read it from the StreamBrowserDialog UI later
Fixed digital channel properties.
…now that value has been cached on all drivers implementing it).
@jwise jwise force-pushed the jwise/stream-browser-more-helpful branch from e194562 to ceb5be6 Compare October 8, 2024 07:45
@jwise
Copy link
Contributor Author

jwise commented Oct 8, 2024

Here's where @fredzo and I landed on this so far:

image

I think I'm going to declare this Ready for Review, though I admit that I haven't looked at the diff as a whole yet myself. But this is definitely something that other people should consider testing and playing with; there's support for Siglent, Rigol, and the Demo scope in the scopehal upstream.

@jwise jwise marked this pull request as ready for review October 8, 2024 07:47
@fredzo
Copy link
Contributor

fredzo commented Oct 8, 2024

@jwise I think we should not show status badges on non-slow channels to prevent flickering effect:
ngscopeclient_PJ9B6BHj6F

@azonenberg azonenberg merged commit ff70b36 into ngscopeclient:master Oct 10, 2024
5 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants