-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich UI support for StreamBrowserDialog on oscilloscopes #765
Rich UI support for StreamBrowserDialog on oscilloscopes #765
Conversation
…e, and fall back on a shorter string if there is not
…e, and then read it from the StreamBrowserDialog UI later
Fixed digital channel properties.
…now that value has been cached on all drivers implementing it).
…the timeout behavior, tweak some more UI)
…ress if there is not enough space for both
…nteresting properties
e194562
to
ceb5be6
Compare
Here's where @fredzo and I landed on this so far: I think I'm going to declare this Ready for Review, though I admit that I haven't looked at the diff as a whole yet myself. But this is definitely something that other people should consider testing and playing with; there's support for Siglent, Rigol, and the Demo scope in the scopehal upstream. |
@jwise I think we should not show status badges on non-slow channels to prevent flickering effect: |
…per method on Oscilloscope. Fixed looping on PollTrigger() when scope is in Run mode.
This is a draft PR to experiment with some UI for #760 and #761, and in general, the concept of making the StreamBrowserDialog meaningfully richer in showing instrument and system status. Here is what I have right now:
Obviously there is going to be a lot of stuff to add and cleanup to do before this is ready to merge, and probably will include some scopehal changes, but this is the current UI metaphor set that I'm playing with. Title bars are still draggable, for instance, but other parts are not, and I think this makes some sense. Some things to consider at some point: