ci: switch from dtslint to ESLint
#2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `dtslint` dependency because it was deprecated a long time ago and is no longer maintained. The issue was with supporting newer TypeScript versions, as `dtslint` uses an older TypeScript compiler API. We now use `eslint-plugin-expect-type` to lint against `$Expect` comments.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f86cc6c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
BundleMon (Integration Projects)Unchanged files (2)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
|
Code Climate has analyzed commit f86cc6c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.5% (0.0% change). View more on Code Climate. |
arturovt
requested review from
markwhitfeld,
kuncevic,
Carniatto,
poloagustin,
joaqcid and
splincode
as code owners
rhutchison
approved these changes
Mar 1, 2024
|
Great find! I'm glad we have a decent dtslint replacement now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
dtslintdependency because it was deprecated a long time ago and is no longer maintained. The issue was with supporting newer TypeScript versions, asdtslintuses an older TypeScript compiler API. We now useeslint-plugin-expect-typeto lint against$Expectcomments.