kickban.py: Fix ban slash command

nh-server · Oct 10, 2024 · 6997f23 · 6997f23
1 parent 4694865
commit 6997f23
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/cogs/kickban.py b/cogs/kickban.py
@@ -137,27 +137,28 @@ async def ban_member_slash(self,
             unban_time = timestamp + delta
             unban_time_string = format_dt(unban_time)
 
+            msg += f"\n\nThis ban expires in {unban_time_string}."
+            msg_send = await send_dm_message(member, msg)
+
             try:
                 await interaction.guild.ban(member, reason=reason, delete_message_days=delete_messages)
             except discord.errors.Forbidden:
                 await interaction.response.send_message("Failed to ban member.")
                 return
 
             await self.restrictions.add_restriction(member, Restriction.Ban, reason, end_date=unban_time)
-            msg += f"\n\nThis ban expires in {unban_time_string}."
-            msg_send = await send_dm_message(member, msg)
             await interaction.response.send_message(f"{member} is now b& until {unban_time_string}. 👍" + ("\nFailed to send DM message" if not msg_send else ""))
         else:
             unban_time = None
+            msg += "\n\nThis ban does not expire."
+            msg_send = await send_dm_message(member, msg)
             try:
                 await interaction.guild.ban(member, reason=reason, delete_message_days=delete_messages)
             except discord.errors.Forbidden:
                 await interaction.response.send_message("Failed to ban member.")
                 return
 
             await self.restrictions.remove_restriction(member, Restriction.Ban)
-            msg += "\n\nThis ban does not expire."
-            msg_send = await send_dm_message(member, msg)
             await interaction.response.send_message(f"{member} is now b&. 👍" + ("\nFailed to send DM message" if not msg_send else ""))
         await self.bot.logs.post_action_log(interaction.user, member, 'ban', reason=reason, until=unban_time)