Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions and changes to hardware cmd's #1330

Merged
merged 8 commits into from
Jul 21, 2024
Merged

Conversation

Retroomer
Copy link
Contributor

0 from #hardware here. PR includes additions and small rewrites to the .hardware cmd, including:

  • .hardware battery
  • .hardware buying
  • .hardware glossary
  • .hardware guides
  • .hardware ipa
  • .hardware modding
  • .hardware screws
  • .hardware shells
  • .hardware soldering

Some additional notes:

  • I'm making the bold assumption that Discord URL's are parsed and properly shown as can be seen in the image below. If this is not the case, I'll change the Discord URL's to markdown.
    image.
  • I've uploaded thumbnail images to Imgur via a dedicated account. These should be permanently available and not expire/be deleted.
  • This PR also includes a minor bugfix in assistancehardware.py from @Wurmatron under commit a2c1265.

(contents have been reviewed by @Wurmatron)

@fyredragon69
Copy link
Contributor

i have a suggestion in relation to the images, and that is to use @eip618's vps to host the images. thoughts? that way if imgur or the images get removed, they still exist on eip's vps

@Retroomer
Copy link
Contributor Author

Retroomer commented Jul 19, 2024

i have a suggestion in relation to the images, and that is to use @eip618's vps to host the images. thoughts? that way if imgur or the images get removed, they still exist on eip's vps

That'd be great. I was considering adding the images to a wiki somewhere, but there's no "hardware" wiki to upload the images to (correct me if I'm wrong). I agree with the sentiment of Imgur being unreliable.

I assume there's no means of me accessing said VPS, Could someone with VPS access do this for me?
PR in eip618/eiphax-nh#3 has been created & commit replacing Imgur URL's with nintendohomebrew.com URL's has been pushed. Will post a new comment once PR in eiphax-nh has been merged.

Retroomer added a commit to Retroomer/eiphax-nh that referenced this pull request Jul 19, 2024
@eip618 eip618 merged commit 4cfb404 into nh-server:main Jul 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants