feat(typedef): add export IntercomAPI in the typedef #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies all, this is definitely something that should have been merged a while ago. See #73 but this should be addressed by this, so I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nhagen Here's an attempt to close issue #58 - Thanks @jakemmarsh for adding the
index.d.tsin the PR #52 - It seems that one exported member has been left out, and this PR includes it.This is a non-breaking change PR. It's also an important addition for Typescript users that currently see the error when trying to:
import { IntercomAPI } from 'react-intercom':[ts] Module "react-intercom/index" has no exported member 'IntercomAPI'.
Even though the
IntercomAPIis being exported in theindex.js, it was not being exported in theindex.d.ts. This PR addsIntercomAPIin the definition file.@pingshunhuang Hopefully you'll be able to use
react-intercomin your Typescript projects soon when this PR is merged.