fix: apply widget syntax in WYSIWYG replaceSelection API and remove widget syntax in getMarkdown() API
#1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seonim-ryu
reviewed
Mar 8, 2021
|
이견 없습니다. 고생하셨어요~ |
shiren
approved these changes
Mar 9, 2021
apps/editor/src/widget/rules.ts
Outdated
| @@ -29,7 +29,7 @@ export function createWidgetContent(info: string, content: string) { | |||
| export function widgetToDOM(info: string, content: string) { | |||
| const { rule, toDOM } = widgetRuleMap[info]; | |||
|
|
|||
| content = trailingWidgetSyntax(content).match(rule)![0]; | |||
| content = unwrapWidgetSyntax(content).match(rule)![0]; | |||
There was a problem hiding this comment.
저 위쪽은 text고 여기는 왜 content에요? 미묘하게 다른 것이 있나요??
There was a problem hiding this comment.
아 동일합니다. 이쪽을 미처 변경못했네요~text로 변경해둘게요
js87zz
force-pushed
the
fix/remove-widget-syntax
branch
from
0e15994 to
0b0d310
Compare
…nsertText() in WYSIWYG)
js87zz
force-pushed
the
fix/remove-widget-syntax
branch
from
3999fd5 to
8c31c6b
Compare
|
Hi team, is it possible that this change is creating this bug: #2663 ? For some reason, the widget syntax is just not being removed at all :-( Thanks! |
ahamelers
pushed a commit
to ahamelers/tui.editor
that referenced
this pull request
Aug 21, 2023
… widget syntax in `getMarkdown()` API (nhn#1423) * fix: apply widget rules in WYSIWYG API(replaceSelection) * fix: unwrap widget text in getMarkdown() API * refactor: change trailingWidgetSyntax to unwrapWidgetSyntax * chore: add widget node test case(getMarkdown(), replaceSelection(), insertText() in WYSIWYG) * chore: apply code review * chore: apply code review - 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
replaceSelectionAPI when matched with widget text rules$$widget0 ... $$) on callinggetMarkdown()APIThank you for your contribution to TOAST UI product. 🎉 😘 ✨