Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default exclusions for the example code #174

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −0
Open

add default exclusions for the example code #174

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a68381
add default exclusions for the example code
walteck Oct 7, 2024
121c03e
Merge branch 'main' into chwa1-exclude-examples
regularfry Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add default exclusions for the example code
  • Loading branch information
@walteck
walteck committed Oct 7, 2024
commit 7a68381859e2763b1ddba0ddb67e5bbf990e9d22
1 change: 1 addition & 0 deletions scripts/config/sonar-scanner.properties
View file
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@ sonar.host.url=https://sonarcloud.io
sonar.qualitygate.wait=true
sonar.sourceEncoding=UTF-8
sonar.sources=.
sonar.exclusions=docs/**,scripts/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/** is fine, but I don't think we want to exclude scripts/**. There's quite a lot of shell and make in there that we do want covered.

I've also removed the python hello_world example so the original motivating failures for this PR should (I think) have gone away.


#sonar.python.coverage.reportPaths=.coverage/coverage.xml
#sonar.[javascript|typescript].lcov.reportPaths=.coverage/lcov.info