Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic test infrastructure #86

Merged
merged 19 commits into from
Jul 20, 2023

Conversation

regularfry
Copy link
Contributor

Description

This PR adds make tasks for running tests.

Context

This issue says that we're out of alignment with wider policy in the sense that we're applying stricter rules than government policy requires.

There are two ways to solve this: we can either loosen our rules, or make them easier to comply with. From the point of view of the test statuses we require in the quality framework here, this does the latter.

Specifically it allows the user of the template to put scripts into scripts/test for running the various types of test required by the software-engineering-quality-framework which, until they are implemented, will output a warning to the console (but do not fail).

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copy link
Contributor

@stefaniuk stefaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@regularfry This PR establishes a very clean and easy-to-follow pattern. It would be good to get it merged. I've made some comments and suggestions for changes to ensure it matches the existing style of writing. Thank you!

scripts/test.mk Outdated Show resolved Hide resolved
scripts/test.mk Outdated Show resolved Hide resolved
scripts/test.mk Show resolved Hide resolved
scripts/test.mk Outdated Show resolved Hide resolved
scripts/test.mk Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Copy link
Contributor

@stefaniuk stefaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefaniuk stefaniuk enabled auto-merge July 18, 2023 13:43
Signed-off-by: regularfry <[email protected]>
Signed-off-by: regularfry <[email protected]>
Github markdown and the markdownlint tool we're using disagree about what a code block in a footnote should look like.  This patch removes the footnote and moves the content inline.

Signed-off-by: regularfry <[email protected]>
auto-merge was automatically disabled July 19, 2023 08:52

Head branch was pushed to by a user without write access

@stefaniuk stefaniuk added this pull request to the merge queue Jul 20, 2023
Merged via the queue into nhs-england-tools:main with commit 80f1748 Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants