[SPIKE] Update to simplified grid layout from GOV.UK Frontend #1307
colinrotherhampull-request.yml
on: pull_request
Sonar analysis
51s
Code style checks
34s
Javascript unit tests
1m 1s
Visual regression tests
2m 41s
Annotations
6 errors and 5 warnings
|
grid system › @govuk-grid-column mixin › outputs the CSS required for a column in the grid:
packages/core/tools/grid.unit.test.js#L120
expect(received).toBe(expected) // Object.is equality
- Expected - 2
+ Received + 1
.nhsuk-grid-column-full {
box-sizing: border-box;
- width: 100%;
padding: 0 16px;
}
- @media (min-width: 46.25em) {
+ @media (min-width: 61.25em) {
.nhsuk-grid-column-full {
width: 100%;
float: left;
}
}
at Object.toBe (packages/core/tools/grid.unit.test.js:120:27)
|
|
grid system › @govuk-grid-column mixin › allows different widths to be specified using $width:
packages/core/tools/grid.unit.test.js#L148
expect(received).toBe(expected) // Object.is equality
- Expected - 2
+ Received + 1
.nhsuk-grid-column-two-thirds {
box-sizing: border-box;
- width: 100%;
padding: 0 16px;
}
- @media (min-width: 46.25em) {
+ @media (min-width: 61.25em) {
.nhsuk-grid-column-two-thirds {
width: 66.6666666667%;
float: left;
}
}
at Object.toBe (packages/core/tools/grid.unit.test.js:148:27)
|
|
grid system › @govuk-grid-column mixin › allows columns to float right using $float: right:
packages/core/tools/grid.unit.test.js#L231
expect(received).toBe(expected) // Object.is equality
- Expected - 2
+ Received + 1
.nhsuk-grid-column-one-half-right {
box-sizing: border-box;
- width: 100%;
padding: 0 16px;
}
- @media (min-width: 46.25em) {
+ @media (min-width: 61.25em) {
.nhsuk-grid-column-one-half-right {
width: 50%;
float: right;
}
}
at Object.toBe (packages/core/tools/grid.unit.test.js:231:27)
|
|
grid system › @govuk-grid-column mixin › includes the class name by default (deprecated):
packages/core/tools/grid.unit.test.js#L257
expect(received).toBe(expected) // Object.is equality
- Expected - 2
+ Received + 1
.nhsuk-grid-column-full {
box-sizing: border-box;
- width: 100%;
padding: 0 16px;
}
- @media (min-width: 46.25em) {
+ @media (min-width: 61.25em) {
.nhsuk-grid-column-full {
width: 100%;
float: left;
}
}
at Object.toBe (packages/core/tools/grid.unit.test.js:257:27)
|
|
grid system › @govuk-grid-column mixin › allows the class name to be overridden (deprecated):
packages/core/tools/grid.unit.test.js#L283
expect(received).toBe(expected) // Object.is equality
- Expected - 2
+ Received + 1
.large-column-three-quarters {
box-sizing: border-box;
- width: 100%;
padding: 0 16px;
}
- @media (min-width: 46.25em) {
+ @media (min-width: 61.25em) {
.large-column-three-quarters {
width: 75%;
float: left;
}
}
at Object.toBe (packages/core/tools/grid.unit.test.js:283:27)
|
|
Javascript unit tests
Process completed with exit code 1.
|
|
Code style checks
Failed to save: Failed to CreateCacheEntry: Received non-retryable error: Failed request: (409) Conflict: cache entry with the same key, version, and scope already exists
|
|
Code style checks
Cache not found for keys: node-cache-Linux-x64-npm-bb80881960005a451864a12d0936217c46c1421b68f8bcb26c4dc7c56c368df8
|
|
Javascript unit tests
Cache not found for keys: node-cache-Linux-x64-npm-bb80881960005a451864a12d0936217c46c1421b68f8bcb26c4dc7c56c368df8
|
|
Visual regression tests
Cache not found for keys: node-cache-Linux-x64-npm-bb80881960005a451864a12d0936217c46c1421b68f8bcb26c4dc7c56c368df8
|
|
Visual regression tests
Failed to save: Failed to CreateCacheEntry: Received non-retryable error: Failed request: (409) Conflict: cache entry with the same key, version, and scope already exists
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
Backstop report
|
22.7 MB |
|