Skip to content

Commit

Permalink
Merge pull request #962 from nhsuk/change-example-hrefs-to-hash
Browse files Browse the repository at this point in the history
Change example links to a hash
  • Loading branch information
anandamaryon1 authored Jun 10, 2024
2 parents 6ddc867 + e6708f7 commit a790ee0
Show file tree
Hide file tree
Showing 7 changed files with 32 additions and 32 deletions.
12 changes: 6 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,15 @@ We removed the need to add the last breadcrumb outside of the 'Items' list, now
{{ breadcrumb({
items: [
{
href: "/level-one",
href: "#",
text: "Level one"
},
{
href: "/level-one/level-two",
href: "#",
text: "Level two"
}
],
href: "/level-one/level-two/level-three",
href: "#",
text: "Level three"
}) }}
```
Expand All @@ -150,15 +150,15 @@ You will now only need this:
{{ breadcrumb({
items: [
{
href: "/level-one",
href: "#",
text: "Level one",
},
{
href: "/level-one/level-two",
href: "#",
text: "Level two"
},
{
href: "/level-one/level-two/level-three",
href: "#",
text: "Level three"
}
]
Expand Down
16 changes: 8 additions & 8 deletions app/components/all.njk
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,15 @@
items: [
{
text: "Home",
href: "https://www.nhs.uk/"
href: "#"
},
{
text: "Health A-Z",
href: "https://www.nhs.uk/conditions"
href: "#"
},
{
text: "Abscess",
href: "https://www.nhs.uk/conditions/abscess/"
href: "#"
}
]
}) }}
Expand All @@ -89,26 +89,26 @@
{{ contentsList({
items: [
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/",
href: "#",
text: "What is AMD?",
current: "true"
},
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/symptoms/",
href: "#",
text: "Symptoms"
},
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/getting-diagnosed/",
href: "#",
text: "Getting diagnosed"
}
,
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/treatment/",
href: "#",
text: "Treatments"
}
,
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/living-with-amd/",
href: "#",
text: "Living with AMD"
}
]
Expand Down
8 changes: 4 additions & 4 deletions app/components/breadcrumb/index.njk
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,21 @@
{{ breadcrumb({
items: [
{
href: "/level-one",
href: "#",
text: "Level one",
attributes: {lang: "en"}
},
{
href: "/level-one/level-two",
href: "#",
text: "Level two"
},
{
href: "/level-one/level-two/level-three",
href: "#",
text: "Level three",
attributes: {lang: "en"}
}
],
href: "/level-one/level-two/level-three/level-four",
href: "#",
text: "Level four",
classes: "example-class-one example-class-two",
attributes: {lang: "en"}
Expand Down
2 changes: 1 addition & 1 deletion app/components/button/link.njk
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="nhsuk-grid-column-two-thirds">
{{ button({
"text": "Link button",
"href": "/nhsuk-frontend/"
"href": "/"
}) }}
</div>
</div>
Expand Down
10 changes: 5 additions & 5 deletions app/components/contents-list/index.njk
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,26 @@
{{ contentsList({
items: [
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/",
href: "#",
text: "What is AMD?",
current: "true"
},
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/symptoms/",
href: "#",
text: "Symptoms"
},
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/getting-diagnosed/",
href: "#",
text: "Getting diagnosed"
}
,
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/treatment/",
href: "#",
text: "Treatments"
}
,
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/living-with-amd/",
href: "#",
text: "Living with AMD"
}
]
Expand Down
6 changes: 3 additions & 3 deletions packages/components/breadcrumb/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,16 @@ Find out more about the breadcrumb component and when to use it in the [NHS digi
{{ breadcrumb({
items: [
{
href: "/level-one",
href: "#",
text: "Level one",
attributes: {lang: "en"}
},
{
href: "/level-one/level-two",
href: "#",
text: "Level two"
},
{
href: "/level-one/level-two/level-three",
href: "#",
text: "Level three"
}
],
Expand Down
10 changes: 5 additions & 5 deletions packages/components/contents-list/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,26 +41,26 @@ Find out more about the contents list component and when to use it in the [NHS d
{{ contentsList({
items: [
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/",
href: "#",
text: "What is AMD?",
current: "true"
},
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/symptoms/",
href: "#",
text: "Symptoms"
},
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/getting-diagnosed/",
href: "#",
text: "Getting diagnosed"
}
,
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/treatment/",
href: "#",
text: "Treatments"
}
,
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/living-with-amd/",
href: "#",
text: "Living with AMD"
}
]
Expand Down

0 comments on commit a790ee0

Please sign in to comment.