Skip to content

Commit

Permalink
Update header navigation label
Browse files Browse the repository at this point in the history
  • Loading branch information
paulrobertlloyd committed Nov 14, 2024
1 parent 1ba3a91 commit d6f4038
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 6 deletions.
16 changes: 16 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
# NHS.UK frontend Changelog

## Unreleased

:wrench: **Fixes**

- Update header navigation label from ’Primary navigation’ to ‘Menu’, and remove superfluous `role` and `id` attributes. To update your HTML, replace:

```html
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
```

with

```html
<nav class="nhsuk-navigation" aria-label="Menu">
```

## 9.1.0 - 4 November 2024

:new: **New features**
Expand Down
10 changes: 5 additions & 5 deletions packages/components/header/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ compiled JavaScript for all components `nhsuk.min.js` or the individual componen
</div>
<div class="nhsuk-navigation-container">
<div class="nhsuk-width-container">
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
<nav class="nhsuk-navigation" aria-label="Menu">
<ul class="nhsuk-header__navigation-list">
<li class="nhsuk-header__navigation-item">
<a class="nhsuk-header__navigation-link" href="https://www.nhs.uk/conditions">
Expand Down Expand Up @@ -157,7 +157,7 @@ compiled JavaScript for all components `nhsuk.min.js` or the individual componen
</div>
<div class="nhsuk-navigation-container">
<div class="nhsuk-width-container">
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
<nav class="nhsuk-navigation" aria-label="Menu">
<ul class="nhsuk-header__navigation-list">
<li class="nhsuk-header__navigation-item">
<a class="nhsuk-header__navigation-link" href="https://www.nhs.uk/conditions">
Expand Down Expand Up @@ -425,7 +425,7 @@ compiled JavaScript for all components `nhsuk.min.js` or the individual componen
</div>
<div class="nhsuk-navigation-container">
<div class="nhsuk-width-container">
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
<nav class="nhsuk-navigation" aria-label="Menu">
<ul class="nhsuk-header__navigation-list">
<li class="nhsuk-header__navigation-item">
<a class="nhsuk-header__navigation-link" href="#">
Expand Down Expand Up @@ -549,7 +549,7 @@ compiled JavaScript for all components `nhsuk.min.js` or the individual componen
</div>
<div class="nhsuk-navigation-container">
<div class="nhsuk-width-container">
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
<nav class="nhsuk-navigation" aria-label="Menu">
<ul class="nhsuk-header__navigation-list">
<li class="nhsuk-header__navigation-item">
<a class="nhsuk-header__navigation-link" href="#">
Expand Down Expand Up @@ -674,7 +674,7 @@ compiled JavaScript for all components `nhsuk.min.js` or the individual componen
</div>
<div class="nhsuk-navigation-container">
<div class="nhsuk-width-container">
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
<nav class="nhsuk-navigation" aria-label="Menu">
<ul class="nhsuk-header__navigation-list">
<li class="nhsuk-header__navigation-item">
<a class="nhsuk-header__navigation-link" href="#">
Expand Down
2 changes: 1 addition & 1 deletion packages/components/header/template.njk
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@

{% if showNav == "true" and params.primaryLinks %}
<div class="nhsuk-navigation-container">
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
<nav class="nhsuk-navigation" aria-label="Menu">
<ul class="nhsuk-header__navigation-list {%- if params.primaryLinks.length < 4 %} nhsuk-header__navigation-list--left-aligned{% endif %}">
{%- for item in params.primaryLinks %}
<li class="nhsuk-header__navigation-item {%- if item.classes %} {{ item.classes }}{% endif %}" {{- nhsukAttributes(item.attributes) }}>
Expand Down

0 comments on commit d6f4038

Please sign in to comment.