Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase contrast of focused NHS logo in header #1047

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

paulrobertlloyd
Copy link
Contributor

@paulrobertlloyd paulrobertlloyd commented Oct 9, 2024

Description

(Split out from #1000)

  • Update the NHS logo in the header to use a single path, as opposed to paths for the containing rectangle and the NHS letters.
  • This means the log can appear with greater contrast, inherit global focus styles, and require less CSS to style.

As this changes the HTML markup, this is a breaking change.

Before After
before-w800-logo-focus w800-logo-focus
before-w800-organisation-logo-focus w800-organisation-logo-focus

Checklist

@paulrobertlloyd paulrobertlloyd added 💥 breaking change header Code improvements Any changes that improve but do not alter the appearance of the site labels Oct 9, 2024
@paulrobertlloyd paulrobertlloyd changed the title Use single path for NHS logo in header Increase contrast of focused NHS logo in header Oct 9, 2024
@paulrobertlloyd
Copy link
Contributor Author

Urgh, no idea why tests are failing, as I fixed those issues flagged in the linter. Hmmm.

Copy link
Collaborator

@anandamaryon1 anandamaryon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, shaves off some bytes too 👍

I think we should hold back the breaking changes to release together with others, rather than drip feeding them, so I'll leave this open for now.

@frankieroberto
Copy link
Contributor

@anandamaryon1 @paulrobertlloyd can this be closed now as it’s been included within #1058 (Header breaking changes)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 breaking change Code improvements Any changes that improve but do not alter the appearance of the site header
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants