Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR performs a deep dive on the CSS for the header and its various components. These styles have accumulated over time, with many rules applied in multiple instances, needlessly set or unset, or not inheriting values where they could.
This PR also fixes the issue where overflowing navigation items don’t get rolled up into the dropdown menu on desktop (I’ve pulled this into a separate, non-breaking PR – #1060).
These modifier classes are no longer needed:
.nhsuk-header__logo--only
.nhsuk-header__transactional--logo
There are a few stylistic changes too:
nhsuk-spacing(3)
, 16px v 20px); this saves space and uses a defined value.There are 43 updated backstop images; reviewing these I think demonstrate how these changes should hopefully be for the better.
Checklist