Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update header navigation label #1073

Merged
merged 16 commits into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,17 @@
- Fix appearance of disabled warning buttons ([Issue 1034]([https://github.com/nhsuk/nhsuk-service-manual-community-backlog/issues/1034]))
- Fix reverse button text colour ([PR 1080]([https://github.com/nhsuk/nhsuk-frontend/pull/1080]))
- Fix details component requiring html param in uppercase ([PR 1090](https://github.com/nhsuk/nhsuk-frontend/pull/1090), [Issue 1089](https://github.com/nhsuk/nhsuk-frontend/issues/1089))
- Update header navigation label from ’Primary navigation’ to ‘Menu’, and remove superfluous `role` and `id` attributes. To update your HTML, replace:

```html
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
```

with

```html
<nav class="nhsuk-navigation" aria-label="Menu">
```

:boom: **Breaking changes**

Expand Down
4 changes: 2 additions & 2 deletions app/components/header/index.njk
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@
text: 'Mental health'
},
{
'url' : 'https://www.nhs.uk/conditions/social-care-and-support/',
href: 'https://www.nhs.uk/conditions/social-care-and-support/',
text: 'Care and support'
},
{
'url' : 'https://www.nhs.uk/pregnancy/',
href: 'https://www.nhs.uk/pregnancy/',
text: 'Pregnancy'
},
{
Expand Down
10 changes: 5 additions & 5 deletions packages/components/header/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ compiled JavaScript for all components `nhsuk.min.js` or the individual componen
</div>
<div class="nhsuk-navigation-container">
<div class="nhsuk-width-container">
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
<nav class="nhsuk-navigation" aria-label="Menu">
<ul class="nhsuk-header__navigation-list">
<li class="nhsuk-header__navigation-item">
<a class="nhsuk-header__navigation-link" href="https://www.nhs.uk/conditions">
Expand Down Expand Up @@ -144,7 +144,7 @@ compiled JavaScript for all components `nhsuk.min.js` or the individual componen
</div>
<div class="nhsuk-navigation-container">
<div class="nhsuk-width-container">
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
<nav class="nhsuk-navigation" aria-label="Menu">
<ul class="nhsuk-header__navigation-list">
<li class="nhsuk-header__navigation-item">
<a class="nhsuk-header__navigation-link" href="https://www.nhs.uk/conditions">
Expand Down Expand Up @@ -363,7 +363,7 @@ compiled JavaScript for all components `nhsuk.min.js` or the individual componen
</div>
<div class="nhsuk-navigation-container">
<div class="nhsuk-width-container">
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
<nav class="nhsuk-navigation" aria-label="Menu">
<ul class="nhsuk-header__navigation-list">
<li class="nhsuk-header__navigation-item">
<a class="nhsuk-header__navigation-link" href="#">
Expand Down Expand Up @@ -475,7 +475,7 @@ compiled JavaScript for all components `nhsuk.min.js` or the individual componen
</div>
<div class="nhsuk-navigation-container">
<div class="nhsuk-width-container">
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
<nav class="nhsuk-navigation" aria-label="Menu">
<ul class="nhsuk-header__navigation-list">
<li class="nhsuk-header__navigation-item">
<a class="nhsuk-header__navigation-link" href="#">
Expand Down Expand Up @@ -588,7 +588,7 @@ compiled JavaScript for all components `nhsuk.min.js` or the individual componen
</div>
<div class="nhsuk-navigation-container">
<div class="nhsuk-width-container">
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
<nav class="nhsuk-navigation" aria-label="Menu">
<ul class="nhsuk-header__navigation-list">
<li class="nhsuk-header__navigation-item">
<a class="nhsuk-header__navigation-link" href="#">
Expand Down
2 changes: 1 addition & 1 deletion packages/components/header/template.njk
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@

{%- if params.primaryLinks and params.primaryLinks.length > 0 %}
<div class="nhsuk-navigation-container">
<nav class="nhsuk-navigation" id="header-navigation" role="navigation" aria-label="Primary navigation">
<nav class="nhsuk-navigation" aria-label="Menu">
<ul class="nhsuk-header__navigation-list {%- if params.primaryLinks.length < 4 %} nhsuk-header__navigation-list--left-aligned{% endif %}">
{%- for item in params.primaryLinks %}
{% set linkInnerContent %}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading