Change primaryLinks to use href and text instead of url and label #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the link to `"/"` labelled `"Home"`, which is currently hardcoded, and only shows up within the navigation menu on mobile screen widths. This link may not be appropriate for all services, which might not have a homepage, or might use a different path for it. It is also unclear whether having a homepage link is always needed in the navigation if the NHS logo also goes to the homepage.
Change the primaryLinks in the Header component to use `href` and `text` param names instead of `url` and `label`. This improves consistency with other components. The previous param names are still supported for backwards-compatibility (but could be dropped in future?)
frankieroberto
requested review from
edwardhorsford,
anandamaryon1,
paulrobertlloyd and
vickytnz
|
Yes, been meaning to suggest this. Worth making the corresponding change to the footer component too? While we're at it, shall we change |
edwardhorsford
approved these changes
Nov 28, 2024
paulrobertlloyd
force-pushed
the
header-breaking-changes
branch
from
9ab62ce to
a1ee8c1
Compare
|
@edwardhorsford depends if we want to keep it backwards-compatible or not (currently in the PR it is). But I was thinking that this would go out with all the other Header changes in the next breaking change release – this PR is to merge into the other PR for that, #1058. |
|
I'll merge this into #1058 for now, and we can decide whether to keep the backwards-compatibility later. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a mix of components which use
hrefandtextfor links (Action link, Back link, Breadcrumbs, Card, Contents list, Summary list, Skip link, Task list) and those which useurlandlabel(Header and Footer)This is pretty confusing, and caught me out again the other day.
Given we’re changing the Header component anyway, maybe now is the time to switch it over to
hrefandtextfor improved consistency?We could continue to support the old param names (as this PR current does) for backwards-compatibility, or drop them and advise people to switch over straight away?