Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate new header and footer style #881

Merged
merged 45 commits into from
Sep 28, 2023
Merged

Conversation

roshaanbajwa
Copy link
Collaborator

Incorporate the current nhs.uk header and footer CSS style into the frontend library.

Currently, this code only exists in nhs.uk as beta code. It is crucial to have it placed in a central repository accessible to all apps

@roshaanbajwa roshaanbajwa marked this pull request as draft August 8, 2023 12:19
packages/components/footer/template.njk Outdated Show resolved Hide resolved
app/pages/about.njk Outdated Show resolved Hide resolved
packages/components/footer/_footer.scss Outdated Show resolved Hide resolved
packages/components/footer/_footer.scss Outdated Show resolved Hide resolved
packages/components/footer/template.njk Outdated Show resolved Hide resolved
packages/components/header/README.md Outdated Show resolved Hide resolved
packages/components/header/README.md Outdated Show resolved Hide resolved
tests/integration/jsdom/header.test.js Outdated Show resolved Hide resolved
Copy link
Contributor

@andymantell andymantell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs backstop images regenerating for existing and new examples.

@pflynny pflynny marked this pull request as ready for review September 27, 2023 10:05
packages/components/footer/README.md Outdated Show resolved Hide resolved
packages/components/footer/README.md Outdated Show resolved Hide resolved
packages/components/footer/README.md Outdated Show resolved Hide resolved
packages/components/footer/template.njk Outdated Show resolved Hide resolved
packages/components/footer/README.md Outdated Show resolved Hide resolved
packages/components/footer/README.md Outdated Show resolved Hide resolved
packages/components/footer/template.njk Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@andymantell andymantell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog entry

@roshaanbajwa roshaanbajwa merged commit e3df8c0 into main Sep 28, 2023
2 checks passed
@roshaanbajwa roshaanbajwa deleted the new-header-footer branch September 28, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update header and footer components Footer text/bg colour combination fails contrast checks at AAA
5 participants