Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 20 #928

Closed
wants to merge 11 commits into from
Closed

Update to Node 20 #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4249513
update node and remove hrefs
roshaanbajwa Mar 5, 2024
3de045c
add button link
roshaanbajwa Mar 5, 2024
047ccf1
update backstop
roshaanbajwa Mar 5, 2024
9e1a218
remove page.waitfor()
roshaanbajwa Mar 6, 2024
4498d37
update backstop refs
roshaanbajwa Mar 6, 2024
5a034fe
testing upgrade
sikanderakbarali Mar 6, 2024
bfba3f4
refs
roshaanbajwa Mar 7, 2024
a370187
revert refs
roshaanbajwa Mar 7, 2024
622e367
update refs
roshaanbajwa Mar 7, 2024
d25d01e
update puppeteer
roshaanbajwa Mar 7, 2024
94bcf89
update button redirect
roshaanbajwa Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 5 additions & 0 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ jobs:

steps:
- uses: actions/checkout@v2

- uses: actions/setup-node@v1
with:
node-version: 20
registry-url: https://registry.npmjs.org/

- name: Install dependencies
run: npm install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

- uses: actions/setup-node@v1
with:
node-version: 16
node-version: 20
registry-url: https://registry.npmjs.org/

- name: Install dependencies
Expand Down
10 changes: 5 additions & 5 deletions app/components/contents-list/index.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,26 @@
{{ contentsList({
items: [
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/",
href: "#",
text: "What is AMD?",
current: "true"
},
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/symptoms/",
href: "#",
text: "Symptoms"
},
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/getting-diagnosed/",
href: "#",
text: "Getting diagnosed"
}
,
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/treatment/",
href: "#",
text: "Treatments"
}
,
{
href: "https://www.nhs.uk/conditions/age-related-macular-degeneration-amd/living-with-amd/",
href: "#",
text: "Living with AMD"
}
]
Expand Down
12 changes: 6 additions & 6 deletions app/components/header/header-navigation.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,27 +10,27 @@
"showSearch": "false",
"primaryLinks": [
{
"url" : "https://www.nhs.uk/conditions",
"url" : "#",
"label" : "Health A-Z"
},
{
'url' : 'https://www.nhs.uk/live-well/',
'url' : '#',
'label' : 'Live Well'
},
{
'url' : 'https://www.nhs.uk/mental-health/',
'url' : '#',
'label' : 'Mental health'
},
{
'url' : 'https://www.nhs.uk/conditions/social-care-and-support/',
'url' : '#',
'label' : 'Care and support'
},
{
'url' : 'https://www.nhs.uk/pregnancy/',
'url' : '#',
'label' : 'Pregnancy'
},
{
'url' : 'https://www.nhs.uk/nhs-services/',
'url' : '#',
'label' : 'NHS services'
}
]
Expand Down
12 changes: 6 additions & 6 deletions app/components/header/header-search.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,27 +10,27 @@
"showSearch": "true",
"primaryLinks": [
{
"url" : "https://www.nhs.uk/conditions",
"url" : "#",
"label" : "Health A-Z"
},
{
'url' : 'https://www.nhs.uk/live-well/',
'url' : '#',
'label' : 'Live Well'
},
{
'url' : 'https://www.nhs.uk/mental-health/',
'url' : '#',
'label' : 'Mental health'
},
{
'url' : 'https://www.nhs.uk/conditions/social-care-and-support/',
'url' : '#',
'label' : 'Care and support'
},
{
'url' : 'https://www.nhs.uk/pregnancy/',
'url' : '#',
'label' : 'Pregnancy'
},
{
'url' : 'https://www.nhs.uk/nhs-services/',
'url' : '#',
'label' : 'NHS services'
}
]
Expand Down
12 changes: 6 additions & 6 deletions app/components/header/index.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,27 +10,27 @@
"showSearch": "true",
"primaryLinks": [
{
"url" : "https://www.nhs.uk/conditions",
"url" : "#",
"label" : "Health A-Z"
},
{
'url' : 'https://www.nhs.uk/live-well/',
'url' : '#',
'label' : 'Live Well'
},
{
'url' : 'https://www.nhs.uk/mental-health/',
'url' : '#',
'label' : 'Mental health'
},
{
'url' : 'https://www.nhs.uk/conditions/social-care-and-support/',
'url' : '#',
'label' : 'Care and support'
},
{
'url' : 'https://www.nhs.uk/pregnancy/',
'url' : '#',
'label' : 'Pregnancy'
},
{
'url' : 'https://www.nhs.uk/nhs-services/',
'url' : '#',
'label' : 'NHS services'
}
]
Expand Down
4 changes: 2 additions & 2 deletions app/components/pagination/index.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
<div class="nhsuk-grid-row">
<div class="nhsuk-grid-column-two-thirds">
{{ pagination({
"previousUrl": "/section/treatments",
"previousUrl": "#",
"previousPage": "Treatments",
"nextUrl": "/section/symptoms",
"nextUrl": "#",
"nextPage": "Symptoms"
}) }}
</div>
Expand Down
Loading
Loading