Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds aria-hidden to labels that show on small screens, to avoid scree… #942

Merged
merged 4 commits into from
May 30, 2024

Conversation

anandamaryon1
Copy link
Collaborator

@anandamaryon1 anandamaryon1 commented Apr 29, 2024

Description

adds aria-hidden to labels in responsive tables that show on small screens, to avoid screenreaders calling out the labels/column headings twice

Checklist

I've tested this locally but do not have access to all of the software and platforms mentioned in out testing criteria.
tested via VoiceOver on MacOS in Edge and Chrome. UPDATE: Tested in Lab with NVDA and JAWS, works as expected.

@anandamaryon1 anandamaryon1 marked this pull request as ready for review May 20, 2024 14:36
@anandamaryon1 anandamaryon1 requested a review from Fenwick17 May 20, 2024 14:36
@anandamaryon1 anandamaryon1 merged commit 9903d45 into main May 30, 2024
2 checks passed
@anandamaryon1 anandamaryon1 deleted the fix-responsive-table-label-aria branch May 30, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants