Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update label margins to match fieldsets and align with GOV.UK #946

Merged
merged 6 commits into from
May 14, 2024

Conversation

edwardhorsford
Copy link
Contributor

@edwardhorsford edwardhorsford commented May 13, 2024

Description

This updates the bottom margins of labels to better match those of legends. I've followed a bit of how GOV.UK structures these.

At the moment I think the label margins are overly large - too separated from the hint or inputs they relate to. GOV.UK doesn't have responsive margins for these - the label margins are all fixed and the same as the fieldset legends.

The only label that doesn't now match fieldset legends is the small size - where it follows the no modifier size 1.

XL label before
xl-before

XL label after
xl-after

L label before
l-before

L label after
l-after

M label before
m-before

M label after
m-after

S label before
s-before

S label after
s-after

No modifier label before
no-modifier-before

No modifier label after
no-modifier-after

Fixes #947

Checklist

@edwardhorsford edwardhorsford marked this pull request as ready for review May 13, 2024 11:40
anandamaryon1
anandamaryon1 previously approved these changes May 14, 2024
Copy link
Collaborator

@anandamaryon1 anandamaryon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible change, helps to group labels with their inputs and now matches fieldset legends. Looks good thank you.

Copy link
Collaborator

@anandamaryon1 anandamaryon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch with the backstop reference images

@anandamaryon1 anandamaryon1 merged commit ee44e23 into main May 14, 2024
2 checks passed
@anandamaryon1 anandamaryon1 deleted the update-label-margins branch May 14, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label bottom margins are too large
3 participants