Fix inset-text not supporting html param #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankieroberto
previously approved these changes
May 17, 2024
frankieroberto
approved these changes
May 21, 2024
frankieroberto
added a commit
that referenced
this pull request
Jun 27, 2024
The inset text component was updated to support a lowercase `html` param in #951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #950. I think we expect all Nunjucks arguments to be lowercase - but here is is uppercase.
I think it would be a breaking change to swap it over, so I've added support for
params.htmlin preference whilst still acceptingparams.HTML. It could potentially be considered cleaning up for a future major version release.