Let page width be overridden #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankieroberto
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Seems sensible to me. I’ve tended to use modifier classes like app-width-container--wide to override the page width, but that’s partly because I forget the sass variables exist.
Modifier classes are still useful if you have 2 different page widths in your service (rare, but can happen!).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
$nhsuk-page-widthto be a SASS default, which would let teams override it. Nearly every other item inglobals.scsscan be overridden already. This works the same way as GOV.UK for setting page width.Checklist