Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make copyright statement settable via params #975

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

frankieroberto
Copy link
Contributor

This de-duplicates 2 areas where the copyright statement is set (depending on the number of columns of links), and also allows the copyright text to be set using params.copyright on the Nunjucks macro.

This was previously documented as an option on the footer component but wasn’t implemented in the actual nunjucks macro.

Screenshot showing the text: 'copyright string false Optional text for the copyright notice in the footer'

I’ve set the default to "NHS England" as the guidance suggests that’s what most services should use, but the NHS.UK website, or any local NHS trusts or other organisations, could override this.

This de-duplicates 2 areas where the copyright statement is set (depending on the number of columns of links), and also allows the copyright text to be set using `params.copyright` on the Nunjucks macro.
@frankieroberto
Copy link
Contributor Author

Possibly this should follow the pattern of having copyright.text and copyright.html instead, but the labels for the links in the footer don’t seem to do that so I wasn’t sure how rigidly we wanted to follow the pattern? 🤷‍♂️

@roshaanbajwa roshaanbajwa merged commit dd7282b into main Jun 27, 2024
2 checks passed
@roshaanbajwa roshaanbajwa deleted the make-copyight-text-settable-via-params branch June 27, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants