Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Adding an 'account' section to header #983

Closed
wants to merge 8 commits into from

Conversation

frankieroberto
Copy link
Contributor

@frankieroberto frankieroberto commented Jul 10, 2024

Description

This section would allow you to add 'account' related items at the top-right of the header, like this:

Screenshot 2024-07-10 at 14 18 44

The items can be either links (if an href is present) or just text or HTML, in order to allow for maximum flexibility.

Resolves nhsuk/nhsuk-service-manual-community-backlog#192

Checklist

Allows the items to be more flexible
@frankieroberto
Copy link
Contributor Author

Our current thinking is to basically allow the account items to stack on the right on mobile at the point where they no longer fit.

The service name could also wrap onto 2 or more lines if needed, but remaining to the right of the logo instead of dropping beneath it.

Example here (spacing is all a bit rough still):

Screenshot 2024-07-16 at 09 20 17

@Tosin-Balogun
Copy link

@frankieroberto this is wicked, I saw this from the slack thread around headers. Do you have a prototype hosted anywhere we can inspect?

@chrimesdev
Copy link
Member

LGTM this would be useful on Screening & happy to test in our service.

@frankieroberto
Copy link
Contributor Author

@frankieroberto this is wicked, I saw this from the slack thread around headers. Do you have a prototype hosted anywhere we can inspect?

@Tosin-Balogun Not yet - although if you clone this repo and checkout this branch and then run npm start you can see some working examples!

LGTM this would be useful on Screening & happy to test in our service.

@chrimesdev we’re not quite there yet, but hopefully soon!

@paulrobertlloyd
Copy link
Contributor

paulrobertlloyd commented Nov 20, 2024

Replaced by #1063.

@paulrobertlloyd paulrobertlloyd deleted the add-account-section-to-header branch November 20, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header for 'logged in' users
5 participants