Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes macro #998

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Add attributes macro #998

merged 3 commits into from
Aug 22, 2024

Conversation

edwardhorsford
Copy link
Contributor

@edwardhorsford edwardhorsford commented Aug 20, 2024

Description

This adds the attributes macro from the GOV.UK Design system and uses it across NHSUK Frontend.

Updated using several variations of find and replace. I've searched for for attribute and there are no matching results.

frankieroberto
frankieroberto previously approved these changes Aug 20, 2024
Copy link
Contributor

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@paulrobertlloyd
Copy link
Contributor

Brill! Let’s get this merged, shall we?

roshaanbajwa
roshaanbajwa previously approved these changes Aug 22, 2024
Copy link
Collaborator

@roshaanbajwa roshaanbajwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@edwardhorsford edwardhorsford merged commit 2e93f62 into main Aug 22, 2024
2 checks passed
@edwardhorsford edwardhorsford deleted the add-attributes-macro branch August 22, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants