Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serviceName local in start page template #414

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

frankieroberto
Copy link
Contributor

@frankieroberto frankieroberto commented Nov 17, 2024

Currently the Create pages step of the basic prototype tutorial says to copy and paste the start-page.html template and then:

You'll normally edit the HTML to make changes to pages, but the service name is in a config file. This is so we can change it in one place to update it on every page in your prototype.

However currently the <h1> and pageTitle (used for <title> tag) has a hardcoded start name. 🤦

It makes sense for this to be dynamic, so let’s use the local serviceName variable instead.

Fixes #413 - thanks @anandamaryon1 for reporting.

Checklist

  • CHANGELOG entry

@frankieroberto frankieroberto merged commit 66806f9 into main Nov 18, 2024
4 checks passed
@frankieroberto frankieroberto deleted the use-service-name-local-in-start-page branch November 18, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service name is hard-coded in start-page template
3 participants