-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds devcontainer.json for Codespaces and container use #428
Conversation
Copied from nhsuk/nhsuk-prototype-kit#428 for testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I tested this by copying the config into the prototype for the service I’m working on and it worked (after I, um, fixed a typo I introduced).
The one thing that doesn’t seem to work yet is BrowserSync. When I look at the javascript console for the codespace there seems to be a access control issue with the XMLHttpRequest call that BrowserSync uses:
Any ideas? Not a blocker though - can still do manual refreshes for now.
Ah.. Good spot! I thought that was working but I might have made that up because it does the same for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve tested this and it all works (apart from the livereload feature but that’s not blocking and can be fixed later). 👍
Suggest we release this and test it out with a few people and then put out some guidance for it in https://prototype-kit.service-manual.nhs.uk later.
Description
This PR adds a devcontainer.json file to the Prototype Kit repository. A devcontainer.json file is a configuration file used by Github and Visual Studio Code (as well as other tools) to define a development environment inside a container.
This file is part of the Dev Containers feature, which lets us standardise the Prototype Kit coding setup within GitHub Codespaces.
What does this configuration do?
npm install
once it has been created.npm run watch
each time a user attaches (opens the Codespace).Checklist