Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add navigation menu? #93

Closed
vickytnz opened this issue Nov 6, 2024 · 4 comments
Closed

Add navigation menu? #93

vickytnz opened this issue Nov 6, 2024 · 4 comments
Labels
Content Improvements or additions to documentation Nunjucks Pull requests that involve nunjucks functionality SASS / CSS type: enhancement 💡 New feature or request

Comments

@vickytnz
Copy link
Contributor

vickytnz commented Nov 6, 2024

Using a structure like NHS notify would allow us to both have a consistent navigation and also free up the area underneath the hero image to have key benefits.

image from govuk notifiy
@vickytnz vickytnz converted this from a draft issue Nov 6, 2024
@vickytnz
Copy link
Contributor Author

vickytnz commented Nov 6, 2024 •
edited
Loading

A mockup of navigation.

NHS.UK prototype kit page of benefits underneath

@vickytnz vickytnz changed the title Add navigation to prototype kit? Add navigation to prototype kit document site? Nov 11, 2024
@frankieroberto frankieroberto changed the title Add navigation to prototype kit document site? Add navigation to prototype kit website? Nov 12, 2024
@frankieroberto
Copy link
Contributor

I like this idea (and I also tried this out locally) but I think we should settle on the Information architecture first?

I'm not yet sure whether Templates should stay on the documentation site or be in the kit only or remain in both - see #60

Also had an idea that we could add Support (#91) and Contribution (#92) pages which could then go in the nav?

Also do we want to stick with 'How to guides' or pick another label for that? 🤷

@vickytnz
Copy link
Contributor Author

Agree - I've made a separate ticket #102 as I think that redoing the structure will then make the menu more valuable (it will also mean we have a natural home for showing the benefit of the kit #50

@vickytnz vickytnz added the Content Improvements or additions to documentation label Nov 19, 2024
@frankieroberto frankieroberto changed the title Add navigation to prototype kit website? Add navigation menu? Nov 19, 2024
@frankieroberto frankieroberto mentioned this issue Nov 26, 2024
Merged
@frankieroberto frankieroberto linked a pull request Nov 26, 2024 that will close this issue
Add main nav #153
Merged
@vickytnz vickytnz added type: enhancement 💡 New feature or request Nunjucks Pull requests that involve nunjucks functionality SASS / CSS labels Nov 27, 2024
@frankieroberto frankieroberto removed a link to a pull request Nov 27, 2024
Add main nav #153
Merged
frankieroberto added a commit that referenced this issue Nov 27, 2024
@frankieroberto
Add main nav (#153)
8f11d8c 
This adds a "primary nav" with 3 items:

* Get started
* Guides
* Support

"Contribute" could be added when #148 is merged.

I’ve not included "Page templates" as that page feels less valuable
longer-term (eg if the NHS website templates get moved to a plugin or
something).

Adding the primary nav possibly means that some of the breadcrumbs could
be removed or shortened (eg the "Home" breadcrumb link on Support feels
a bit odd now?), but the Service Manual website has both, so maybe it’s
fine?

There’s no "current section" indicator for now, but we can adopt that
when it gets added to the header in the next major release of NHS
frontend (hopefully).

Part of #93
@vickytnz
Copy link
Contributor Author

vickytnz commented Dec 1, 2024

Closing this issue as I think it is covered by other thigns

@vickytnz vickytnz closed this as completed Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Content Improvements or additions to documentation Nunjucks Pull requests that involve nunjucks functionality SASS / CSS type: enhancement 💡 New feature or request
Projects
NHS prototype kit project board (info in 'project details')
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frankieroberto @vickytnz