Add main nav #153
Merged
Add main nav #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankieroberto
temporarily deployed
to
nhs-prototyp-add-main-n-fda1y6
Closed
frankieroberto
requested review from
vickytnz,
edwardhorsford and
anandamaryon1
vickytnz
requested changes
Nov 27, 2024
There was a problem hiding this comment.
This looks good - however when I looked on smaller screen sizes a home button randomly shows up?
I was initially going to flag just for the purposes of maybe checking about the padding but then realised an extra link had appeared. It doesn't seem to be a problem on NHS notify (thought the padding is a thing) so it's a bit of a mystery as to where it's coming from.
|
@vickytnz that’s a known issue with the Header nav - see nhsuk/nhsuk-frontend#986 Will be fixed as part of nhsuk/nhsuk-frontend#1058 |
vickytnz
approved these changes
Nov 27, 2024
frankieroberto
temporarily deployed
to
nhs-prototyp-add-main-n-fda1y6
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "primary nav" with 3 items:
"Contribute" could be added when #148 is merged.
I’ve not included "Page templates" as that page feels less valuable longer-term (eg if the NHS website templates get moved to a plugin or something).
Adding the primary nav possibly means that some of the breadcrumbs could be removed or shortened (eg the "Home" breadcrumb link on Support feels a bit odd now?), but the Service Manual website has both, so maybe it’s fine?
There’s no "current section" indicator for now, but we can adopt that when it gets added to the header in the next major release of NHS frontend (hopefully).
Part of #93