-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed guides page as reference for site #136
Merged
vickytnz
merged 5 commits into
main
from
102-review-and-change-information-architecture
Nov 21, 2024
Merged
Changed guides page as reference for site #136
vickytnz
merged 5 commits into
main
from
102-review-and-change-information-architecture
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankieroberto
temporarily deployed
to
nhs-prototyp-102-review-veae9r
November 19, 2024 21:40
Inactive
frankieroberto
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer! 🙌
Left a few minor comments.
Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
vickytnz
commented
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all accepted
vickytnz
commented
Nov 21, 2024
frankieroberto
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of reviewing the information architecture, my hypothesis is that making the guides page work harder can help us make some decisions about the site.
It also includes the getting started section links (as does the GOV.UK Prototype Kit guide) which I hypothesis helps with findability.
Not included:
This may also help resolved #9 re-findability of how-to guides.