Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site to v5.2 of the kit #188

Closed
wants to merge 1 commit into from
Closed

Conversation

vickytnz
Copy link
Contributor

Site updated with files for v5.2

This now makes it work on Codespaces, though i have noticed that it seems to make it run on port 3001 rather than 3000 which may need documenting somewhere (or at least some troubleshooting in case it's something to do with my setup).

@vickytnz vickytnz marked this pull request as ready for review December 15, 2024 18:34
@frankieroberto frankieroberto temporarily deployed to nhs-prototyp-187-update-afexua December 15, 2024 18:34 Inactive
Copy link
Contributor

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it makes sense to copy all these changes from the prototype kit back into the docs site. Whilst the 2 repos started off the same, we’ve been teasing them apart.

The docs site doesn't really need to 'use' the prototype kit itself - it can just be a simple Express site which uses NHS Frontend in a similar way.

It could even be switched to using a static site generator framework instead like Eleventy or Jekyll or Metalsmith or Hugo - which would be cheaper to host. But currently we do have a single example of a dynamic page (the branching example) which prevents it - and @edwardhorsford did suggest that we could add some more dynamic examples (eg validation?) in future.

It might be worth closing this pull request and re-opening smaller ones with any of the useful changes from the NHS prototype kit that we might want to copy across (eg devcontainer.json)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add all these example templates back into the docs site, as that’ll just confuse us in future – they should remain in the prototype kit repo only.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file isn't needed for the docs site as there’s not authentication needed.

@vickytnz
Copy link
Contributor Author

vickytnz commented Dec 16, 2024

I'm not sure it makes sense to copy all these changes from the prototype kit back into the docs site. Whilst the 2 repos started off the same, we’ve been teasing them apart.

The docs site doesn't really need to 'use' the prototype kit itself - it can just be a simple Express site which uses NHS Frontend in a similar way.

It could even be switched to using a static site generator framework instead like Eleventy or Jekyll or Metalsmith or Hugo - which would be cheaper to host. But currently we do have a single example of a dynamic page (the branching example) which prevents it - and @edwardhorsford did suggest that we could add some more dynamic examples (eg validation?) in future.

It might be worth closing this pull request and re-opening smaller ones with any of the useful changes from the NHS prototype kit that we might want to copy across (eg devcontainer.json)?

That's fair - though I'd like that documented somewhere. Interestingly I think the branching examples should go as tehy're tricky to maintain and in the govuk version are so buried that I didn't know they existed (I'd also say inconsistent given we don't have code examples of the basic tutorial but only screenshots).

Strictly speaking we don't need codespaces for the docs site, it was more that Paul's pull request had gone stale and so out of curiosity I wanted to try codespaces only for everything to just break.

@vickytnz vickytnz closed this Dec 16, 2024
@vickytnz vickytnz deleted the 187-update-site-to-v52 branch December 16, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prototype kit has codespaces, Docs doesn't and trying to use it breaks everything
2 participants