Added Streaming Tests to Testing Suite #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ni-sujain
requested changes
Aug 31, 2023
There was a problem hiding this comment.
add steps for the python client test naming convention
There was a problem hiding this comment.
for Record Route Implementation just make sure that we are passing some valid value.
ni-sujain
reviewed
Aug 31, 2023
There was a problem hiding this comment.
what changes do have here, you can revert this file
ni-sujain
approved these changes
Aug 31, 2023
tests/New_ATS/README.md
Outdated
| @@ -88,13 +88,12 @@ Follow the below steps to add more tests in the testing suite. | |||
|
|
|||
| 9. Inside the `testcases` folder, create a json file for each rpc method defined in the protofile. The name of the json file will be same as the rpc method's name. These will contain the testcases that the testing suite will run corresponding to each rpc method. | |||
|
|
|||
| 10. Create a python client that will interact with the LabVIEW gRPC Server. The name of the client will be like `<test_name>_client.py`. | |||
| 10. Create a `Python_client` folder and add python clients for each rpc into it that will interact with the LabVIEW gRPC Server. The name of the client will be like `<rpc_name>_client.py`. | |||
There was a problem hiding this comment.
Its not a hard requirement to match the client python file name with the rpc_name, it's just a recommendation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.