Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included 'MessageConverterProxy.vim' for deletion after server generation #310

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

yash-ni
Copy link
Collaborator

@yash-ni yash-ni commented Sep 13, 2023

Fix for the issue #304.

Behaviour before the fix

Block diagram of Delete Message Template Files.vi:

pre

  • This VI was removing all files listed in the array. However it was missing 'MessageConverterProxy.vim'. That file was not being added to the labview project but was present on the disk that caused bugs.

Behaviour after the fix

Block diagram of Delete Message Template Files.vi:

after

  • Now it will also delete the 'MessageConverterProxy.vim' file after server generation.

@CPattar-NI
Copy link
Collaborator

We have all the oneof related template file deletions in the "Delete Oneof Template Files.vi", which is called at the end of the "Delete Message Template Files.vi".

Could you add to the list of files in the oneof VI instead?

@yash-ni
Copy link
Collaborator Author

yash-ni commented Sep 13, 2023

We have all the oneof related template file deletions in the "Delete Oneof Template Files.vi", which is called at the end of the "Delete Message Template Files.vi".

Could you add to the list of files in the oneof VI instead?

Couldn't add because the virtual folder is getting deleted from the project before going into the oneof vi.

@yash-ni yash-ni closed this Sep 13, 2023
@yash-ni yash-ni reopened this Sep 13, 2023
@ni-sujain ni-sujain merged commit c9f418d into ni:master Sep 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants