Fix browse for proto imports and other minor cleanup #325
Conversation
… can't get added to the typedef and break it.
…es instead of files when browsing.
There was a problem hiding this comment.
The only change here is hidden in right click configuration options of the path control(s) used to specify directories from which to find imported proto files. The path control is now configured to browse for directories instead of files.
There was a problem hiding this comment.
The only change here is to separate compiled code from source.
There was a problem hiding this comment.
The only change here is to separate compiled code from source.
There was a problem hiding this comment.
I started making changes to this and Create Oneof Message Converters.vi as I was debugging and trying to improve code generation behavior when regenerating code in project in which previously generated code already exists. However, I soon realized making this developer flow work well probably requires an extensive overhaul of the existing code, which is more than I have time for at the moment. However, I decided to submit these VIs anyway since they have been simplified quite a bit, and are much easier to read.
There was a problem hiding this comment.
This VI didn't think it belonged to the library for some reason. Now it does.
There was a problem hiding this comment.
I also modified this while trying to improve behavior of regenerating a proto file without first deleting everything that was previously generated. This change prevents multiple copies of the top level enum from getting added to the typedef, which breaks the typedef. Having a broken typedef in turn generates lots of downstream errors with VI scripting when adding things by path and what not.
|
@pratheekshasn Can you review this PR and/or assign to appropriate reviewers. It appears I don't have write access so I can't add reviewers myself. Would it also be possible for me to get write access to the repo? |
This addresses #186. It also includes changes related to #313 and #38.