Remove singleton behavior for Reflection Plugin Class #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ni-sujain
reviewed
Jul 25, 2024
… when all server stops
ni-sujain
reviewed
Jul 25, 2024
ni-sujain
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #356 and #361
Changes:
Created a new singleton class "ProtoDescriptorString" that will save the current proto string descriptor and can be later used to initialize the reflection service.
Removed singleton behavior of Reflection plugin class "LVProtoServerReflectionPlugin" so that now every server will have its own reflection service and separate descriptor pools.