Cleaning front panel and block diagrams to improve readability. Where… #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… appropriate, extracted out common code or deleted unreferenced code.
…m Whitespace.vi <vilib> dependency which has since been inlined and has inlined sub VI dependencies which didn't exist in 2019.
dixonjoel
reviewed
Nov 20, 2024
There was a problem hiding this comment.
nit: Ctrl + U on the front panel would make it possible to see the .vi name when opening these...
dixonjoel
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am planning to make changes to the code generators in up coming PRs. Before doing so, I am doing a mass cleanup of the existing VIs in this PR to improve readability and minimize diffs for more meaningful changes in the future.
Implementation
There are no intended functional changes as part of this PR. The changes are purely cosmetic in nature to improve readability. Move control/indicator label to the left/right on the block diagram, uncross wires, and that sort of thing. In some cases, common code was extracted and unreferenced code was deleted. There were a few VIs that didn't have source only setting and those have been fixed as well. I also updated the icon for the error code VIs as a solid red background color doesn't play well with the icon editor algorithm in later LV versions. It tends to display the text over the library banner rather than limiting the text to the area below the banner.
Testing