Add values to getting started template for postgres migration user. #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christian-Nunnally
requested review from
JD-Robertson,
prestwick,
BKnight760,
lnowotny and
MelissaHilliard
as code owners
rbell517
approved these changes
Nov 1, 2023
prestwick
approved these changes
Nov 14, 2023
Christian-Nunnally
deleted the
users/cnunnall/update-template-for-postgres-migration-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adding the new values that were added in this PR: https://dev.azure.com/ni/DevCentral/_git/Skyline/pullrequest/589182?_a=files&path=/TestMonitorService/helm/values.yaml to the getting started template with documentation.
Why should this Pull Request be merged?
So that users are aware of the new option of using a separate postgres user for schema migrations.
What testing has been done?
The helm changes have been tested, this is just updating our template to include the new values.