-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sizing yaml template for SystemLink Enterprise pilots #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a sizing file that specifies resources and replicas for a SystemLink Enterprise pilot deployment.
BKnight760
requested review from
JD-Robertson,
prestwick,
lnowotny,
Christian-Nunnally and
MelissaHilliard
as code owners
August 26, 2024 20:35
Alphabetize service list to make it easier for users to find them
Add detailed comments for the polot-sizing.yaml so the user knows what the file does, how to use it and the intended outcome.
prestwick
requested changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know my comment about Mongo might risk our end date, but there is interest in deprecating our support for cluster internal Mongo for SLE. Given that this is likely to happen we should strong consider not using that configuration for pilots.
The default configuration is external MongoDB, even for pilots. Remove these overrides since they are not needed.
Add a comment indicating that production deployments should use the defaults provided in the helm charts, or they could be overridden similarly to this file to increase the resources or replicas for specific workloads.
Indicate in the comments that Pilot deployments use managed MongoDB Atlas or MongoDB Enterprise.
JD-Robertson
approved these changes
Aug 28, 2024
prestwick
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a sizing file that specifies resources and replicas for a SystemLink Enterprise pilot deployment.
What does this Pull Request accomplish?
This pull request adds a new template yaml file that specifies the resources and replica counts for a pilot-sized deployment.
Why should this Pull Request be merged?
Provide customers with a template to speed up initial deployment of pilot environments.
What testing has been done?
Deployed the solution manually and verified that the services start correctly and are capable of handling a reasonable load for a pilot.