-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update angular-eslint to 16 #138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrevorKarjanis
approved these changes
Mar 19, 2024
rajsite
reviewed
Mar 19, 2024
jattasNI
approved these changes
Mar 25, 2024
change/@ni-eslint-config-angular-7bcf1406-f6fc-4336-a2ff-a2fbb32de903.json
Show resolved
Hide resolved
rajsite
reviewed
Apr 9, 2024
rajsite
approved these changes
Apr 9, 2024
mure
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@angular/core
to16.2.12
(latest <17) and@angular-eslint
packages to16.3.1
(latest <17)@angular-eslint/recommended--extra
config no longer exists, I inlined the configuration that used to be in that file in lieu of extending it.accessibility-
prefix, so I updated the names in our template config where we had been disabling those rules.interactive-supports-focus
androle-has-required-aria
), so I added them (in disabled state).Testing
npm run print-evaluated-rules:diff
and ensured that the only differences were the renamed accessibility rules.npm run print-evaluated-rules
to do an audit, which turned up no warnings or diverged rules.npm run print-available-rules
and found that there were the following new, unset rules available in the updated version of @angular-eslint:@angular-eslint/prefer-standalone-component
@angular-eslint/require-localize-metadata
@angular-eslint/sort-lifecycle-methods
@angular-eslint/template/prefer-ngsrc
@angular-eslint/template/prefer-self-closing-tags