Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update angular-eslint to 16 #138

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented Mar 18, 2024

  • Updated dependency on @angular/core to 16.2.12 (latest <17) and @angular-eslint packages to 16.3.1 (latest <17)
  • As the @angular-eslint/recommended--extra config no longer exists, I inlined the configuration that used to be in that file in lieu of extending it.
  • The accessibility rules referenced by the config have been renamed to drop the accessibility- prefix, so I updated the names in our template config where we had been disabling those rules.
  • There were two accessibility rules that were not listed in our template config (interactive-supports-focus and role-has-required-aria), so I added them (in disabled state).
  • Updated all urls in the repo to reference "main" instead of "master"

Testing

  • I ran npm run print-evaluated-rules:diff and ensured that the only differences were the renamed accessibility rules.
  • I ran npm run print-evaluated-rules to do an audit, which turned up no warnings or diverged rules.
  • I ran npm run print-available-rules and found that there were the following new, unset rules available in the updated version of @angular-eslint:
    • @angular-eslint/prefer-standalone-component
    • @angular-eslint/require-localize-metadata
    • @angular-eslint/sort-lifecycle-methods
    • @angular-eslint/template/prefer-ngsrc
    • @angular-eslint/template/prefer-self-closing-tags

packages/eslint-config-angular/index.js Outdated Show resolved Hide resolved
packages/eslint-config-angular/index.js Outdated Show resolved Hide resolved
packages/eslint-config-angular/index.js Outdated Show resolved Hide resolved
packages/eslint-config-angular/index.js Show resolved Hide resolved
@m-akinc m-akinc requested a review from rajsite April 9, 2024 17:19
@rajsite
Copy link
Member

rajsite commented Apr 9, 2024

@m-akinc, don't need to wait for @mure since there should effectively be no rule change. Let me know when ready for the Angular 16 release train and I'll merge.

@rajsite rajsite merged commit 107ef3b into ni:main Apr 10, 2024
1 check passed
@m-akinc m-akinc deleted the users/makinc/angular-eslint16 branch April 10, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants