Project cleanup

.gitignore

@@ -91,3 +91,6 @@ gradle-app.setting
 
 # Paper run
 run/
+
+# Gradle docker cache
+.gradleDocker

build.gradle.kts

@@ -8,6 +8,7 @@ plugins {
     alias(libs.plugins.run.paper)
     alias(libs.plugins.ktlint)
     alias(libs.plugins.detekt)
+    alias(libs.plugins.qodana)
 }
 
 val version: String by project
@@ -91,7 +92,7 @@ tasks {
         mustRunAfter(ktlintFormat)
     }
 
-    create("runChecks") {
+    create("runLints") {
         dependsOn(ktlintFormat, detekt)
     }
 

gradle/libs.versions.toml

@@ -26,6 +26,8 @@ runPaper = "2.3.1"
 ktlint-plugin = "12.1.1"
 # https://detekt.dev/
 detekt-plugin = "1.23.7"
+# https://www.jetbrains.com/help/qodana/qodana-gradle-plugin.html
+qodana = "2024.2.3"
 
 [libraries]
 paper-api = { group = "io.papermc.paper", name = "paper-api", version.ref = "paper-api" }
@@ -45,3 +47,4 @@ shadow = { id = "com.gradleup.shadow", version.ref = "shadow" }
 run-paper = { id = "xyz.jpenilla.run-paper", version.ref = "runPaper" }
 ktlint = { id = "org.jlleitschuh.gradle.ktlint", version.ref = "ktlint-plugin" }
 detekt = { id = "io.gitlab.arturbosch.detekt", version.ref = "detekt-plugin" }
+qodana = { id = "org.jetbrains.qodana", version.ref = "qodana" }

qodana.yaml

@@ -0,0 +1,12 @@
+# Qodana configuration:
+# https://www.jetbrains.com/help/qodana/qodana-yaml.html
+
+version: 1.0
+linter: jetbrains/qodana-jvm-community:2024.2
+projectJDK: "21"
+profile:
+  name: qodana.recommended
+exclude:
+  - name: All
+    paths:
+      - .qodana

src/main/kotlin/com/rose/gateway/config/markers/CommonDecoder.kt

@@ -53,6 +53,6 @@ open class CommonDecoder : NullHandlingDecoder<Any> {
      * @param classifier The class we want to check
      * @return true if it passes all conditions, false otherwise
      */
-    fun isSupportedClassifier(classifier: KClass<*>): Boolean =
+    private fun isSupportedClassifier(classifier: KClass<*>): Boolean =
         !classifier.isData && !classifier.isSealed && !classifier.isInline() && classifier canBe ConfigObject::class
 }

src/main/kotlin/com/rose/gateway/discord/bot/message/GroupAndPaginateItems.kt

@@ -17,7 +17,6 @@ import dev.kord.rest.builder.message.create.FollowupMessageCreateBuilder
  * @receiver Editing paginator builder
  *
  * @see group
- * @see editingPaginator
  */
 suspend fun <T : Any> EphemeralSlashCommandContext<*, *>.groupAndPaginateItems(
     displayItems: Collection<T>,

src/main/kotlin/com/rose/gateway/minecraft/commands/arguments/ConfigListArgs.kt

@@ -35,10 +35,10 @@ open class ConfigListArgs<T : Any, A : ConfigListArgs<T, A, P>, P : ArgParser<T,
  * @param stringValidator The validator to use for each string
  */
 class StringListConfigArgs(
-    val stringCompleter: StringParser<StringListConfigArgs>.(
+    private val stringCompleter: StringParser<StringListConfigArgs>.(
         TabCompleteContext<StringListConfigArgs>,
     ) -> List<String>,
-    val stringValidator: StringParser<StringListConfigArgs>.(
+    private val stringValidator: StringParser<StringListConfigArgs>.(
         ParseResult.Success<String, StringListConfigArgs>,
     ) -> Boolean,
 ) : ConfigListArgs<String, StringListConfigArgs, StringParser<StringListConfigArgs>>(

src/main/kotlin/com/rose/gateway/minecraft/commands/framework/data/context/BukkitContext.kt

@@ -11,7 +11,7 @@ import org.bukkit.command.CommandSender
  * @property args The args that exist for the action
  * @constructor Create a Bukkit context
  */
-public sealed class BukkitContext(
+sealed class BukkitContext(
     val sender: CommandSender,
     val command: Command,
     val args: Array<String>,
@@ -26,7 +26,7 @@ public sealed class BukkitContext(
      * @param command The command that is completing
      * @param args The args that exist at the moment of completion
      */
-    public class TabComplete(
+    class TabComplete(
         sender: CommandSender,
         command: Command,
         val alias: String,
@@ -43,7 +43,7 @@ public sealed class BukkitContext(
      * @param command The command that is executing
      * @param args The args that were passed in for execution
      */
-    public class CommandExecute(
+    class CommandExecute(
         sender: CommandSender,
         command: Command,
         val label: String,

src/main/kotlin/com/rose/gateway/minecraft/commands/framework/data/context/FrameworkContext.kt

@@ -12,7 +12,7 @@ import com.rose.gateway.minecraft.commands.framework.runner.CommandArgs
  * @property args The args in use
  * @constructor Create a framework context
  */
-public sealed class FrameworkContext<A : CommandArgs<A>>(
+sealed class FrameworkContext<A : CommandArgs<A>>(
     val command: Command,
     val args: A,
 ) {
@@ -27,7 +27,7 @@ public sealed class FrameworkContext<A : CommandArgs<A>>(
      * @param command The command in use
      * @param args The args in use
      */
-    public sealed class BukkitCommand<B : BukkitContext, A : CommandArgs<A>>(
+    sealed class BukkitCommand<B : BukkitContext, A : CommandArgs<A>>(
         val bukkit: B,
         command: Command,
         args: A,
@@ -42,7 +42,7 @@ public sealed class FrameworkContext<A : CommandArgs<A>>(
          * @param command The command in use
          * @param args The args in use
          */
-        public class CommandExecute<A : CommandArgs<A>>(
+        class CommandExecute<A : CommandArgs<A>>(
             bukkit: BukkitContext.CommandExecute,
             command: Command,
             args: A,
@@ -59,7 +59,7 @@ public sealed class FrameworkContext<A : CommandArgs<A>>(
          * @param command The command in use
          * @param args The args in use
          */
-        public class TabComplete<A : CommandArgs<A>>(
+        class TabComplete<A : CommandArgs<A>>(
             bukkit: BukkitContext.TabComplete,
             command: Command,
             args: A,
@@ -71,9 +71,9 @@ public sealed class FrameworkContext<A : CommandArgs<A>>(
 /**
  * @see FrameworkContext.BukkitCommand.CommandExecute
  */
-public typealias CommandExecuteContext<A> = FrameworkContext.BukkitCommand.CommandExecute<A>
+typealias CommandExecuteContext<A> = FrameworkContext.BukkitCommand.CommandExecute<A>
 
 /**
  * @see FrameworkContext.BukkitCommand.TabComplete
  */
-public typealias TabCompleteContext<A> = FrameworkContext.BukkitCommand.TabComplete<A>
+typealias TabCompleteContext<A> = FrameworkContext.BukkitCommand.TabComplete<A>

src/main/kotlin/com/rose/gateway/minecraft/component/Color.kt

@@ -20,26 +20,26 @@ object Color : KoinComponent {
      *
      * @return The colored component
      */
-    public fun Component.primary(): Component = this.color(config.primaryColor())
+    fun Component.primary(): Component = this.color(config.primaryColor())
 
     /**
      * Apply the secondary color to the component
      *
      * @return The colored component
      */
-    public fun Component.secondary(): Component = this.color(config.secondaryColor())
+    fun Component.secondary(): Component = this.color(config.secondaryColor())
 
     /**
      * Apply the tertiary color to the component
      *
      * @return The colored component
      */
-    public fun Component.tertiary(): Component = this.color(config.tertiaryColor())
+    fun Component.tertiary(): Component = this.color(config.tertiaryColor())
 
     /**
      * Apply the warning color to the component
      *
      * @return The colored component
      */
-    public fun Component.warning(): Component = this.color(config.warningColor())
+    fun Component.warning(): Component = this.color(config.warningColor())
 }

src/main/kotlin/com/rose/gateway/minecraft/logging/LogFormatter.kt

@@ -12,7 +12,7 @@ import java.util.logging.SimpleFormatter
 class LogFormatter : SimpleFormatter() {
     private val dateTimeFormatter = DateTimeFormatter.ofPattern("EEE, yyyy-MM-dd HH:mm:ss")
 
-    override fun format(record: LogRecord): String? {
+    override fun format(record: LogRecord): String {
         val zdt =
             ZonedDateTime.ofInstant(
                 record.instant,

src/main/kotlin/com/rose/gateway/minecraft/logging/Logger.kt

@@ -11,10 +11,9 @@ import java.util.logging.FileHandler
 object Logger : KoinComponent {
     private val plugin: GatewayPlugin by inject()
     private val pluginLogger = plugin.logger
-    private val handler: FileHandler
+    private val handler: FileHandler = FileHandler(plugin.dataFolder.path.plus("/gateway_log.txt"), true)
 
     init {
-        handler = FileHandler(plugin.dataFolder.path.plus("/gateway_log.txt"), true)
         handler.formatter = LogFormatter()
         pluginLogger.addHandler(handler)
     }

src/main/kotlin/com/rose/gateway/minecraft/server/ServerInfo.kt

@@ -27,7 +27,7 @@ object ServerInfo {
      * @property fifteenMinute The TPS over the past fifteen minutes
      * @constructor Create a TPS snapshot
      */
-    public data class TPS(
+    data class TPS(
         val oneMinute: Double,
         val fiveMinute: Double,
         val fifteenMinute: Double,